Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): changed how endpoints are stored in config file #7

Merged
merged 13 commits into from
Apr 12, 2024

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Apr 11, 2024

changes

  • changes suggested by @jonrkarr in previous PR
  • refactored how we store URLs
  • updates tests to work with refactor
  • added MIT license
  • purged all instances of deep-origin, config now stored in ~/.deeporigin

@sg-s sg-s self-assigned this Apr 11, 2024
@sg-s sg-s marked this pull request as ready for review April 11, 2024 13:26
@sg-s sg-s requested a review from jonrkarr as a code owner April 11, 2024 13:26
@sg-s sg-s changed the title More fixes refactor(cli): changed how endpoints are stored in config gile Apr 11, 2024
@sg-s sg-s changed the title refactor(cli): changed how endpoints are stored in config gile refactor(cli): changed how endpoints are stored in config file Apr 11, 2024
src/config/__init__.py Outdated Show resolved Hide resolved
jonrkarr
jonrkarr previously approved these changes Apr 11, 2024
Copy link
Contributor

@jonrkarr jonrkarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I just noticed we should change the name of the config directory to align with the revised name of this library.

@sg-s sg-s requested a review from jonrkarr April 12, 2024 01:15
@sg-s sg-s enabled auto-merge (squash) April 12, 2024 01:15
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sg-s sg-s merged commit 534dfd6 into main Apr 12, 2024
6 checks passed
@sg-s sg-s deleted the more-fixes branch April 12, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants