Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add scope in setter code to prevent `variable already declared #603 #606

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

lionelhorn
Copy link
Contributor

  • When a tuple definition contained "duplicated" union types like [number|null, number|null], the jitted function couldln't be build as some variable like oldErrors were already declared. Probably one block per number|null

Summary of changes

Added scope

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • [x ] I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

…ared` deepkit#603

- When a tuple definition contained "duplicated" union types like [number|null, number|null], the jitted function couldln't be build as some variable like `oldErrors` were already declared. Probably one block per number|null
@marcj marcj merged commit 9af344f into deepkit:master Aug 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants