Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev tooling deps & npm audit fix #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fergusean
Copy link
Contributor

Summary of changes

Updates lerna and madge to the latest versions, drops coveralls (looks like it hasn't been used since early 2021), and runs an npm audit fix (did not use --force).

Before: 40 vulnerabilities (22 moderate, 14 high, 4 critical)
After: found 0 vulnerabilities

Best I can tell:

  • Lerna 6 as a task runner & publisher is backwards compatible with Lerna 4.
  • Madge doesn't look like it had any breaking changes & isn't used programmatically so I can't audit how you're using it.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #433 (7b50ee3) into master (213c7de) will increase coverage by 0.06%.
The diff coverage is 88.52%.

❗ Current head 7b50ee3 differs from pull request most recent head f272ff9. Consider uploading reports for the commit f272ff9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   78.26%   78.33%   +0.06%     
==========================================
  Files         170      171       +1     
  Lines       18002    18104     +102     
  Branches     4709     4732      +23     
==========================================
+ Hits        14089    14181      +92     
- Misses       3913     3923      +10     
Impacted Files Coverage Δ
packages/http/src/model.ts 64.92% <ø> (+1.57%) ⬆️
packages/http/src/static-serving.ts 0.00% <0.00%> (ø)
packages/event/src/event.ts 60.91% <5.55%> (-4.12%) ⬇️
packages/core/src/core.ts 63.60% <50.00%> (-0.11%) ⬇️
packages/type/src/serializer.ts 92.32% <60.00%> (+0.02%) ⬆️
packages/workflow/src/workflow.ts 86.32% <76.92%> (-1.07%) ⬇️
packages/http/src/kernel.ts 85.71% <91.66%> (+3.66%) ⬆️
packages/injector/src/injector.ts 80.56% <92.85%> (+0.17%) ⬆️
packages/http/src/router.ts 88.38% <93.33%> (-2.17%) ⬇️
packages/http/src/request-parser.ts 96.00% <96.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants