Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect PIECE_VALUE used for multiplication of knights on the evaluate function #68

Open
tolumide-ng opened this issue Oct 20, 2024 · 1 comment

Comments

@tolumide-ng
Copy link

Hello,
Thank you for your hard work and dedication to this project! I really appreciate the effort that goes into maintaining it.
I encountered an issue I think might have been an unintended typo on the evaluate function in position.rs here:

self.board.knights().count_bits() as Eval * PIECE_VALUES[Piece::WK as usize] +

It appears that the PIECE_VALUE of a king was used to multiply the knights count.

Thanks again for your time.

@dede1751
Copy link
Owner

dede1751 commented Nov 6, 2024

Thanks a lot for pointing this out, this is indeed a bug!
Sadly, Carp is not currently in development and although this is a bug standard chess engine development practice is to test every change. I will leave this issue open and try to fire up a test when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants