Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for cmake #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding support for cmake #1

wants to merge 5 commits into from

Conversation

rodgert
Copy link

@rodgert rodgert commented Nov 12, 2015

Building this for Windows/VisualStudio

@eugenwintersberger
Copy link
Contributor

Hi Thomas,
first of all thank you for your contributions. Unfortunately this repository is no longer used for the development of the HDF5 LZ4 filter plugin. Currently the code used in the Ubuntu and Debian packages I maintain comes from an SVN repository maintained by the HDF group.
This repository should have vanished or put to read-only mode already quite a while ago.
I guess I need to discuss this with Michael.

It is planned that the filter plugin repositories are moved to GitHub from the HDF SVN repository. However, currently the HDF crew is pretty occupied with working on the 1.10 release of the HDF5 library and thus does not find the time to deal with the filter topic.

Your work is anyhow highly appreciated as the official HDF policy is to use autotools for Linux and Unix builds and CMake on Windows. Thus we can reuse your work.

May I suggest the following procedure (which I have to discuss with the HDF people)

  • I will push the content of their SVN repository to this repository so that it remains in sync with the new official HDF version
  • we will than try to apply your patches.

Would this be an acceptable procedure for you?

@osti
Copy link

osti commented Feb 21, 2016

Unfortunately this repository is no longer used for the development of the HDF5 LZ4 filter plugin
This is really a pity because it is programmed very cleanly, and the Makefile runs like a charme. Unfortunately, we have a lot of troubles with the “official“ SVN stuff.

@rodgert
Copy link
Author

rodgert commented Mar 12, 2016

Sorry, this notification got buried in my email. I'm fine with it being
incorporated into the "official" HDF5 distribution, but we also recently
discovered that the version of the LZ4 codec used by this library has
significant performance issues and have subsequently replaced the codec
with a current version. Falling back to an official HDF5 distributed
version without the corresponding changes would be problematic for us.

On Sun, Nov 15, 2015 at 5:58 AM, Eugen Wintersberger <
[email protected]> wrote:

Hi Thomas,
first of all thank you for your contributions. Unfortunately this
repository is no longer used for the development of the HDF5 LZ4 filter
plugin. Currently the code used in the Ubuntu and Debian packages I
maintain comes from an SVN repository maintained by the HDF group.
This repository should have vanished or put to read-only mode already
quite a while ago.
I guess I need to discuss this with Michael.

It is planned that the filter plugin repositories are moved to GitHub from
the HDF SVN repository. However, currently the HDF crew is pretty occupied
with working on the 1.10 release of the HDF5 library and thus does not find
the time to deal with the filter topic.

Your work is anyhow highly appreciated as the official HDF policy is to
use autotools for Linux and Unix builds and CMake on Windows. Thus we can
reuse your work.

May I suggest the following procedure (which I have to discuss with the
HDF people)

  • I will push the content of their SVN repository to this repository
    so that it remains in sync with the new official HDF version
  • we will than try to apply your patches.

Would this be an acceptable procedure for you?


Reply to this email directly or view it on GitHub
#1 (comment).

@eugenwintersberger
Copy link
Contributor

Sorry for this late reply. I was pretty occupied with other things the last two month. Anyhow, I do not see a problem adding your current changes to the code to the official HDF5 repository as long as it can handle data which has been compressed by the current version of the code.

@yayahjb
Copy link

yayahjb commented Mar 15, 2016

Don't forget that there is a second copy of the LZ4 kit in the bitshuffle
kit. -- Herbert

On Tue, Mar 15, 2016 at 3:57 AM, Eugen Wintersberger <
[email protected]> wrote:

Sorry for this late reply. I was pretty occupied with other things the
last two month. Anyhow, I do not see a problem adding your current changes
to the code to the official HDF5 repository as long as it can handle data
which has been compressed by the current version of the code.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1 (comment)

@rodgert
Copy link
Author

rodgert commented Mar 15, 2016

In our testing thus far it seems to be fully backwards compatible with the
original version included with hdf5lz4. I will see if I can get a patch
together this week and forward it along.

On Tue, Mar 15, 2016 at 12:57 AM, Eugen Wintersberger <
[email protected]> wrote:

Sorry for this late reply. I was pretty occupied with other things the
last two month. Anyhow, I do not see a problem adding your current changes
to the code to the official HDF5 repository as long as it can handle data
which has been compressed by the current version of the code.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants