From 24b8397a5c4d6dc44f240819bedb4a49c485661e Mon Sep 17 00:00:00 2001 From: Jiyoon Koo Date: Thu, 2 May 2024 19:19:36 -0400 Subject: [PATCH 1/4] pointing to new PR for adding test vectors for select credentials --- web5-spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web5-spec b/web5-spec index 270966f0f..18732728b 160000 --- a/web5-spec +++ b/web5-spec @@ -1 +1 @@ -Subproject commit 270966f0ffab6c8834ab83aeb61855d212b12723 +Subproject commit 18732728b592c2215f4d2785e460139ca7ed57b2 From 972acad2e47a0fd091b1253a8b0a2509593e8ec8 Mon Sep 17 00:00:00 2001 From: Jiyoon Koo Date: Thu, 2 May 2024 20:10:55 -0400 Subject: [PATCH 2/4] debugging test. array filter is failing --- packages/credentials/tests/presentation-exchange.spec.ts | 8 +++++--- web5-spec | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/credentials/tests/presentation-exchange.spec.ts b/packages/credentials/tests/presentation-exchange.spec.ts index 5c4569013..f18b665d0 100644 --- a/packages/credentials/tests/presentation-exchange.spec.ts +++ b/packages/credentials/tests/presentation-exchange.spec.ts @@ -23,7 +23,7 @@ class OtherCredential { ) {} } -describe('PresentationExchange', () => { +describe.only('PresentationExchange', () => { describe('Full Presentation Exchange', () => { let issuerDid: BearerDid; let btcCredentialJwt: string; @@ -287,11 +287,13 @@ describe('PresentationExchange', () => { }); }); - describe('Web5TestVectorsPresentationExchange', () => { - it('select_credentials', async () => { + describe.only('Web5TestVectorsPresentationExchange', () => { + it.only('select_credentials', async () => { const vectors = PresentationExchangeSelectCredentialsTestVector.vectors; for (let i = 0; i < vectors.length; i++) { + console.log("Description: ", vectors[i].description) + // test vector with description "select credentials for presentation, using array filter" is failing. const input = vectors[i].input; const expectedOutput = vectors[i].output.selectedCredentials; diff --git a/web5-spec b/web5-spec index 18732728b..51146ccf3 160000 --- a/web5-spec +++ b/web5-spec @@ -1 +1 @@ -Subproject commit 18732728b592c2215f4d2785e460139ca7ed57b2 +Subproject commit 51146ccf331e8b630d1b198816c3041707f311d0 From 9050f93faef3e9150ff42347b8144a92682c6a68 Mon Sep 17 00:00:00 2001 From: Jiyoon Koo Date: Thu, 2 May 2024 20:28:15 -0400 Subject: [PATCH 3/4] removing .only, bumping submodule commit --- packages/credentials/tests/presentation-exchange.spec.ts | 6 +++--- web5-spec | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/credentials/tests/presentation-exchange.spec.ts b/packages/credentials/tests/presentation-exchange.spec.ts index f18b665d0..040fb91e5 100644 --- a/packages/credentials/tests/presentation-exchange.spec.ts +++ b/packages/credentials/tests/presentation-exchange.spec.ts @@ -23,7 +23,7 @@ class OtherCredential { ) {} } -describe.only('PresentationExchange', () => { +describe('PresentationExchange', () => { describe('Full Presentation Exchange', () => { let issuerDid: BearerDid; let btcCredentialJwt: string; @@ -287,8 +287,8 @@ describe.only('PresentationExchange', () => { }); }); - describe.only('Web5TestVectorsPresentationExchange', () => { - it.only('select_credentials', async () => { + describe('Web5TestVectorsPresentationExchange', () => { + it('select_credentials', async () => { const vectors = PresentationExchangeSelectCredentialsTestVector.vectors; for (let i = 0; i < vectors.length; i++) { diff --git a/web5-spec b/web5-spec index 51146ccf3..358054940 160000 --- a/web5-spec +++ b/web5-spec @@ -1 +1 @@ -Subproject commit 51146ccf331e8b630d1b198816c3041707f311d0 +Subproject commit 35805494018d16bb19194e41fd98184314648315 From 17a729dd8c329f60214bfc10b3a406c283967c4f Mon Sep 17 00:00:00 2001 From: Jiyoon Koo Date: Thu, 2 May 2024 20:48:14 -0400 Subject: [PATCH 4/4] removing extraneous console log --- packages/credentials/tests/presentation-exchange.spec.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/credentials/tests/presentation-exchange.spec.ts b/packages/credentials/tests/presentation-exchange.spec.ts index 040fb91e5..5c4569013 100644 --- a/packages/credentials/tests/presentation-exchange.spec.ts +++ b/packages/credentials/tests/presentation-exchange.spec.ts @@ -292,8 +292,6 @@ describe('PresentationExchange', () => { const vectors = PresentationExchangeSelectCredentialsTestVector.vectors; for (let i = 0; i < vectors.length; i++) { - console.log("Description: ", vectors[i].description) - // test vector with description "select credentials for presentation, using array filter" is failing. const input = vectors[i].input; const expectedOutput = vectors[i].output.selectedCredentials;