Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to only keep the proofs about the two most recent log update entries? #143

Open
swcurran opened this issue Nov 29, 2024 · 2 comments

Comments

@swcurran
Copy link
Collaborator

The following question came up in the review of PR #136.

@PatStLouis : Does it make sense to instead only keep the proofs about the two most recent log update entries?

@swcurran
Copy link
Collaborator Author

Perhaps it is enough, but I’m not sure…. That’s what we stated we would do in the original witness design.

That means that a witnesses for the last version are the de facto witnesses for all of the versions in the file. As we have defined it now, the actual witnesses for each version are retained — with the witnesses themselves asserting their approval of all prior versions they witnessed. The transitive approval is already being used — is it OK across witnesses?

It does get trickier the witness process can be disabled as discussed in #140. In that case, does the DID Witness file go away, or do we keep the file with the witnesses for the last witnessed version of the DID?

@andrewwhitehead
Copy link
Contributor

It does get trickier the witness process can be disabled as discussed in https://github.com/decentralized-identity/trustdidweb/issues/140. In that case, does the DID Witness file go away, or do we keep the file with the witnesses for the last witnessed version of the DID?

All the previous witness rules still have to be satisfied by the witness file, for the log line where they take effect or a later one, even if there aren't currently any required witnesses (assuming we allow that to be turned off). So no I don't think you would ever remove the witness file, although you wouldn't need to keep updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants