Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audio stream and fix only current parcel id can plays audio #61

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Oct 14, 2023

  • fix: in the party-time scene the audio is played twice
  • apply and verify component properties
  • load local resources (videos)

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Attention: 417 lines in your changes are missing coverage. Please review.

Comparison is base (e3e68ed) 15.75% compared to head (ddceef1) 15.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   15.75%   15.17%   -0.58%     
==========================================
  Files          75       78       +3     
  Lines        8767     9148     +381     
==========================================
+ Hits         1381     1388       +7     
- Misses       7386     7760     +374     
Files Coverage Δ
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 45.13% <100.00%> (-0.74%) ⬇️
...ust/decentraland-godot-lib/src/av/audio_context.rs 0.00% <0.00%> (ø)
...nd-godot-lib/src/godot_classes/dcl_audio_stream.rs 66.66% <66.66%> (ø)
...-godot-lib/src/scene_runner/components/material.rs 0.00% <0.00%> (ø)
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...nd-godot-lib/src/godot_classes/dcl_video_player.rs 22.22% <22.22%> (ø)
...and-godot-lib/src/scene_runner/deleted_entities.rs 0.00% <0.00%> (ø)
...t/decentraland-godot-lib/src/scene_runner/scene.rs 21.18% <22.22%> (-0.63%) ⬇️
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.35% <0.00%> (-0.01%) ⬇️
rust/decentraland-godot-lib/src/av/video_stream.rs 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review October 18, 2023 19:56
@leanmendoza leanmendoza requested a review from kuruk-mm October 18, 2023 19:56
@kuruk-mm
Copy link
Member

Great work! Everything looks great

@leanmendoza leanmendoza merged commit 60e2fc8 into main Oct 18, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/add-audio-stream branch October 18, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants