Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audio source #59

Merged
merged 5 commits into from
Oct 12, 2023
Merged

feat: add audio source #59

merged 5 commits into from
Oct 12, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Oct 11, 2023

  • Load mp3, wav and ogg
  • only play current scene and global
  • check loop mode works

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (e35a264) 16.42% compared to head (1b68e50) 16.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   16.42%   16.20%   -0.22%     
==========================================
  Files          66       68       +2     
  Lines        8353     8489     +136     
==========================================
+ Hits         1372     1376       +4     
- Misses       6981     7113     +132     
Files Coverage Δ
...aland-godot-lib/src/godot_classes/dcl_camera_3d.rs 66.66% <ø> (ø)
...nd-godot-lib/src/godot_classes/dcl_audio_source.rs 66.66% <66.66%> (ø)
...and-godot-lib/src/scene_runner/deleted_entities.rs 0.00% <0.00%> (ø)
...d-godot-lib/src/scene_runner/components/raycast.rs 0.00% <0.00%> (ø)
...t/decentraland-godot-lib/src/scene_runner/scene.rs 22.34% <15.38%> (-2.17%) ⬇️
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.35% <0.00%> (-0.01%) ⬇️
...ot-lib/src/scene_runner/components/audio_source.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review October 12, 2023 17:52
@leanmendoza leanmendoza merged commit aa57016 into main Oct 12, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/add-audio-source branch October 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants