Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] should we merge wearable and emote props? #42

Open
cazala opened this issue Mar 14, 2022 · 0 comments
Open

[Discussion] should we merge wearable and emote props? #42

cazala opened this issue Mar 14, 2022 · 0 comments

Comments

@cazala
Copy link
Member

cazala commented Mar 14, 2022

searchEmoteRarity and searchEmoteBodyShapes may be combined into a single searchRarity and searchBodyShapes and then get rid of the current searchWearableRarity and searchWearableBodyShapes. The thing is if we wanted to change those it would be a breaking change, so we would need to still support the old ones until migration the nft-server and potentially breaking other integrations. Also, even tho those things are repeated between wearables and emotes, they might not exist on other future type of assets (like 3D assets for the Builder) so it might be OK to let them exist only on the item types that actually use them.

@cazala cazala mentioned this issue Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant