From 3d1a1231e4453b37e945ba2215ba4b5c7c12fb46 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Sun, 29 Jan 2023 11:19:18 +0100 Subject: [PATCH] .github/workflows: Remove golangci-lint The previous commit broke the golangci-lint test [1] because the GitHub Action runs on Ubuntu 22.04, which only has Shadow 4.8 [2], whereas libsubid.so was introduced in Shadow 4.9 [3]. However, that's not a big deal because 'go vet' was earlier added to the set of tests run by 'meson test' [4], and 'go vet' is one of the linters run by golangci-lint [5]. So, while it's not a proper replacement, it's good enough. [1] Commit ca8007c192b3bb77 https://github.com/containers/toolbox/pull/1180 [2] https://packages.ubuntu.com/source/jammy/shadow https://packages.ubuntu.com/source/jammy-updates/shadow [3] Shadow commit 0a7888b1fad613a0 https://github.com/shadow-maint/shadow/commit/0a7888b1fad613a0 https://github.com/shadow-maint/shadow/issues/154 [4] Commit f695012fafec76f0 https://github.com/containers/toolbox/pull/1186 [5] https://golangci-lint.run/usage/linters/ https://golangci-lint.run/usage/linters/#govet This reverts commit 7c86f30b77825f166aef44259e651bf9f50afb23. --- .github/workflows/linting.yaml | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100644 .github/workflows/linting.yaml diff --git a/.github/workflows/linting.yaml b/.github/workflows/linting.yaml deleted file mode 100644 index 3ab6dde4f..000000000 --- a/.github/workflows/linting.yaml +++ /dev/null @@ -1,24 +0,0 @@ -name: Golangci Lint - -on: - push: - branches: - - main - pull_request: - -permissions: - contents: read - pull-requests: read - -jobs: - golangci: - name: Lint - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - - name: golangci-lint - uses: golangci/golangci-lint-action@v2 - with: - version: latest - working-directory: ./src