Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Registry #10

Open
Peep opened this issue Jan 28, 2024 · 1 comment
Open

Windows Registry #10

Peep opened this issue Jan 28, 2024 · 1 comment

Comments

@Peep
Copy link

Peep commented Jan 28, 2024

_rconSubkey = Registry.CurrentUser.OpenSubKey(@"Software\BTK-Development\PalworldRcon", true) ?? Registry.CurrentUser.CreateSubKey(@"Software\BTK-Development\PalworldRcon");

I don't think we should write/use the Windows registry for this kind of program -- and this does fail on some systems. Maybe writing into %userprofile%/AppData would be superior?

I can follow up with a pull request if I get some time, just wanted to mention this.

@MitoG
Copy link

MitoG commented Jan 30, 2024

yeah, writting to the registry, especially writing a clear text password seems like a really bad idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants