Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen dependency restriction to accept jsonschema 4.0 or better still, remove the upper bound #52

Open
groodt opened this issue Jan 14, 2023 · 5 comments
Open

Loosen dependency restriction to accept jsonschema 4.0 or better still, remove the upper bound #52

groodt opened this issue Jan 14, 2023 · 5 comments

Comments

@groodt
Copy link

groodt commented Jan 14, 2023 •
edited
Loading

There is an upper dependency restriction of jsonschema<4.0.

This makes it more difficult to install dbt into environments with other dependencies installed. jsonschema is a widely used dependency, with notable dependent projects such as jupyterlab and precommit.

Please consider loosening, or removing the upper dependency restriction. This has been requested by others as well previously #43 (comment)
@groodt groodt changed the title Support jsonschema >= 4 or better still, remove the upper bound Loosen dependency restriction to accept jsonschema<4.0 or better still, remove the upper bound Jan 14, 2023
@groodt groodt changed the title Loosen dependency restriction to accept jsonschema<4.0 or better still, remove the upper bound Loosen dependency restriction to accept jsonschema 4.0 or better still, remove the upper bound Jan 14, 2023
@jtcohen6 jtcohen6 mentioned this issue Jan 30, 2023
Closed
@nehiljain
Copy link

This is causing serious problem in our poetry setup at the moment. What is the priority on this fix?

@jtcohen6 jtcohen6 linked a pull request Mar 24, 2023 that will close this issue
remove top pin for jsonschema #51
Closed
@r-richmond
Copy link

This should be solved once dbt-labs/dbt-core#7221 is merged 🤞

@dwreeves
Copy link

@r-richmond Any updates on this? It looks like the PR you linked to was merged.

@r-richmond
Copy link

I don't work for DBT but as I understand it the next release of 1.4 and 1.5 will have this fixed.

Personally I forked the 1.3 branch and pulled in that commit and confirm it is working.

@dwreeves
Copy link

ah sorry, my mistake. And thank you for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove top pin for jsonschema bollwyvl/hologram
4 participants
@groodt @nehiljain @r-richmond @dwreeves