-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table of global configs (user configs, env var, and cli flag) #4366
Comments
bump on this! @matthewshaver |
hey @dbeatty10 , this issue isn't similar to this one, right? i think they are slightly different and if so, I'll keep the other open. if they are the same -- what do you think about consolidating it and i can add my write up in yours as yours is more comprehensive? |
Yeah similar, but slightly different! So agreed to keep them both open. Both of these could easily get stale and out-of-date when changes are made to dbt-core. Here is a script that uses We could use a script like this to auto-generate the relationship between CLI flags and sub-commands. I don't think it would cover the relationship between the user config name (for |
[Preview](https://docs-getdbt-com-git-dbeatty-log-cache-events-config-dbt-labs.vercel.app/reference/global-configs/logs#logging-relational-cache-events) resolves #4664 ## What are you changing in this pull request and why? As noted in #4366, there is currently not any documentation for the `log_cache_events` config. When `True`, this flag enables verbose logging for [relational cache](https://docs.getdbt.com/reference/global-configs/cache) events (which can be helpful when debugging) (default to `False`). Because it has existed since at least [2018-11-15](dbt-labs/dbt-core#1139) (prior to dbt v1.0), no version blocks are applicable. ## Checklist - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines.
#4814) resolves #4366 resolves #4709 resolves #4787 ## What are you changing in this pull request and why? - Reframe "global configs" → "flags" - Settable in `dbt_project.yml` instead of `profiles.yml` - Subcategory of flags for legacy behaviors / behavior change migrations <details> <summary> ### Previews </summary> Most important changes: - [website/docs/reference/global-configs/about-global-configs.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/about-global-configs) - [website/docs/reference/global-configs/project-flags.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/project-flags) - [website/docs/reference/dbt_project.yml.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/dbt_project.yml) - [website/docs/reference/global-configs/legacy-behaviors.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/legacy-behaviors) - [website/docs/docs/core/connect-data-platform/profiles.yml.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/docs/core/connect-data-platform/profiles.yml) Other new pages: - [website/docs/reference/global-configs/record-timing-info.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/record-timing-info) - [website/docs/reference/global-configs/indirect-selection.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/indirect-selection) Other significant edits: - [website/docs/reference/global-configs/logs.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/logs) - [website/docs/reference/global-configs/parsing.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/parsing) - [website/docs/reference/global-configs/version-compatibility.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/version-compatibility) - [website/docs/reference/global-configs/json-artifacts.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/global-configs/json-artifacts) - website/sidebars.js - website/vercel.json - website/dbt-versions.js Edited links: - [website/docs/docs/dbt-versions/core-upgrade/08-upgrading-to-v1.2.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/docs/dbt-versions/core-upgrade/upgrading-to-v1.2) - [website/docs/docs/dbt-versions/core-upgrade/10-upgrading-to-v1.0.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/docs/dbt-versions/core-upgrade/upgrading-to-v1.0) - [website/docs/docs/dbt-cloud-apis/sl-manifest.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/docs/dbt-cloud-apis/sl-manifest) - [website/docs/reference/artifacts/dbt-artifacts.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/artifacts/dbt-artifacts) - [website/docs/reference/events-logging.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/events-logging) - [website/docs/reference/parsing.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/parsing) - [website/docs/reference/project-configs/clean-targets.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/project-configs/clean-targets) - [website/docs/reference/resource-configs/severity.md](https://docs-getdbt-com-git-jerco-flags-behavior-changes-dbt-labs.vercel.app/reference/resource-configs/severity) Deleted: - website/docs/reference/global-cli-flags.md - website/docs/reference/global-configs/yaml-configurations.md - website/docs/reference/project-configs/log-path.md - website/docs/reference/project-configs/target-path.md Minor edits (moved and re-titled): - website/docs/reference/global-configs/command-line-options.md Other: - .github/pull_request_template.md </details> ## Checklist Adding or removing pages (delete if not applicable): - [x] Add/remove page in `website/sidebars.js` - [x] Provide a unique filename for new pages - [x] Add an entry for deleted pages in `website/vercel.json` - [x] Run link testing locally with `npm run build` to update the links that point to deleted pages
Proposed solution
It would be awesome if there were dense table of all the global configs and their associated user configs, environment variables, and CLI flags.
Maybe like this (the content of which I have only partially verified):
Not within
dbt_project.yml
Within
dbt_project.yml
as top-level configs instead of underflags:
Caveats
Further verification needed
As noted in #3264, some of the configs listed in the "YAML User Config" column may only work as environment variables and/or CLI flags and might not work within YAML config (like
profiles.yml
).Missing docs
The row for
log_cache_events
above does not have hyperlinks because I didn't see any relevant documentation for this config.Opened #4664 as a result.
Problem
The big idea is that there are a lot of global flags and/or global configs that can be specified in three different ways (lower takes priority):
i.e., if all three are provided, then the CLI flag takes precedence.
But it's not always easy to see what the different options are. In particular, the relevant environment variable is often a guessing game, and the user config name is not always clear either. The CLI flag is the thing that is most consistently included in the documentation and examples, but even that is not always searchable.
Link to the page on docs.getdbt.com requiring updates
Either this page or some other page:
What part(s) of the page would you like to see updated?
See proposed solution above.
Contributions
Additional information
No response
The text was updated successfully, but these errors were encountered: