Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate date_spine macro and sub macros #839

Closed
QMalcolm opened this issue Sep 25, 2023 · 2 comments
Closed

Deprecate date_spine macro and sub macros #839

QMalcolm opened this issue Sep 25, 2023 · 2 comments
Labels
bug Something isn't working Stale triage

Comments

@QMalcolm
Copy link

QMalcolm commented Sep 25, 2023

Describe the bug

We've moved date_spine and it's sub-macros to dbt-core in dbt-labs/dbt-core#8616. As such we should deprecate these macros. The macros to be deprecated are

  • date_spine
  • generate_series
  • get_intervals_between
  • get_powers_of_two

Additional context

We use to have a deprecation function. However, we removed it in a previous PR. We should bring it back. We should also probably keep it around in the future even if nothing is using it at some given point in time as it's always possible more things will get deprecated as time goes on.

Acceptance Criteria

  • A deprecation helper exists again
  • The following have been deprecated: date_spine, generate_series, get_intervals_between, get_powers_of_two
  • Uses of the deprecated functions in dbt-utils now use the dbt-core provided implementations
  • Update docs in README of dbt_utils as-needed [1]

Are you interested in contributing the fix?

Yes

@QMalcolm QMalcolm added bug Something isn't working triage labels Sep 25, 2023
Copy link

github-actions bot commented Apr 4, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 4, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale triage
Projects
None yet
Development

No branches or pull requests

1 participant