From 5deb88864861acc5a367d391cfcbc1c207a0d41a Mon Sep 17 00:00:00 2001 From: Mike Alfare <13974384+mikealfare@users.noreply.github.com> Date: Wed, 3 Apr 2024 15:53:34 -0400 Subject: [PATCH] Add `dbt-core~=1.8.0a1` as convenience dep (#44) --- .changes/unreleased/Dependencies-20240403-135902.yaml | 6 ++++++ hatch_build.py | 2 ++ tests/functional/shared_tests/test_query_comment.py | 8 +++++++- 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .changes/unreleased/Dependencies-20240403-135902.yaml diff --git a/.changes/unreleased/Dependencies-20240403-135902.yaml b/.changes/unreleased/Dependencies-20240403-135902.yaml new file mode 100644 index 00000000..126b2178 --- /dev/null +++ b/.changes/unreleased/Dependencies-20240403-135902.yaml @@ -0,0 +1,6 @@ +kind: Dependencies +body: Add `dbt-core` as a dependency to preserve backwards compatibility for installation +time: 2024-04-03T13:59:02.539298-04:00 +custom: + Author: mikealfare + Issue: "44" diff --git a/hatch_build.py b/hatch_build.py index 02693cf0..a44d06c7 100644 --- a/hatch_build.py +++ b/hatch_build.py @@ -8,6 +8,8 @@ BASE_DEPS = [ # psycopg2 dependency installed in custom hatch_build.py "dbt-adapters>=0.1.0a1,<2.0", + # add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency + "dbt-core>=1.8.0a1", # installed via dbt-adapters but used directly "dbt-common>=0.1.0a1,<2.0", "agate>=1.0,<2.0", diff --git a/tests/functional/shared_tests/test_query_comment.py b/tests/functional/shared_tests/test_query_comment.py index 30399b24..ea2ddeaf 100644 --- a/tests/functional/shared_tests/test_query_comment.py +++ b/tests/functional/shared_tests/test_query_comment.py @@ -6,6 +6,7 @@ BaseNullQueryComments, BaseEmptyQueryComments, ) +import pytest class TestQueryComments(BaseQueryComments): @@ -17,7 +18,12 @@ class TestMacroQueryComments(BaseMacroQueryComments): class TestMacroArgsQueryComments(BaseMacroArgsQueryComments): - pass + @pytest.mark.skip( + "This test is incorrectly comparing the version of `dbt-core`" + "to the version of `dbt-postgres`, which is not always the same." + ) + def test_matches_comment(self, project, get_package_version): + pass class TestMacroInvalidQueryComments(BaseMacroInvalidQueryComments):