Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include node_info in various Result events #9820

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 25, 2024

resolves #9619

Problem

When logging events are sorted into node-specific buckets, the Result events are not included because of the lack of node_info.

Solution

Add node_info to various Result events in core/dbt/task/printer.py

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner March 25, 2024 21:23
@cla-bot cla-bot bot added the cla:yes label Mar 25, 2024
@gshank gshank marked this pull request as draft March 25, 2024 21:23
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.04%. Comparing base (c071868) to head (60d283b).
Report is 3 commits behind head on main.

Files Patch % Lines
core/dbt/task/printer.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9820      +/-   ##
==========================================
- Coverage   88.10%   88.04%   -0.06%     
==========================================
  Files         178      178              
  Lines       22461    22461              
==========================================
- Hits        19789    19776      -13     
- Misses       2672     2685      +13     
Flag Coverage Δ
integration 85.42% <90.00%> (-0.15%) ⬇️
unit 61.73% <30.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank marked this pull request as ready for review March 27, 2024 15:24
@gshank gshank requested a review from MichelleArk March 27, 2024 15:25
@gshank gshank merged commit cfaacc6 into main Mar 27, 2024
62 checks passed
@gshank gshank deleted the result_logging_node_info branch March 27, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing unit test displayed in system logs, not at the node level
2 participants