Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] regardless if the catalog query itself is pre-filtered or not, post-filter its results #9666

Closed
3 tasks done
Tracked by #9425
graciegoheen opened this issue Feb 26, 2024 · 1 comment
Closed
3 tasks done
Tracked by #9425
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented Feb 26, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Originally from #9394

If I use a selector with dbt docs generate, I expect only the selected nodes to be returned in the catalog.json

Acceptance criteria

  • regardless if the catalog query itself is pre-filtered or not, post-filter its results
  • i.e., dbt docs generate -s a b c tag:one_hundred_models should only include those 103 models within catalog.json, even if there are 2000 models within the project.
@MichelleArk
Copy link
Contributor

I ended up addressing this as part of #9755!

Tests here: https://github.com/dbt-labs/dbt-mantle/blob/main/tests/functional/docs/test_generate.py#L156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants