Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3169] [Bug] .yaml prefix not recognized for packages.yml #8738

Closed
2 tasks done
andy-clapson opened this issue Sep 28, 2023 · 3 comments
Closed
2 tasks done

[CT-3169] [Bug] .yaml prefix not recognized for packages.yml #8738

andy-clapson opened this issue Sep 28, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@andy-clapson
Copy link
Contributor

andy-clapson commented Sep 28, 2023

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

If I create a valid packages.yaml in my project directory and run dbt deps, it fails to find any dependencies. If I change the file extension to be .yml, things work fine.

Expected Behavior

I would expect .yaml and .yml to be interchangeable (and there seems to be an interface to handle both...? Maybe not used in some cases). If not, at least a warning pointing me to the issue.

Steps To Reproduce

  1. Create new project
  2. Create/copy packages.yaml file
  3. run dbt deps

Relevant log output

{"data": {"log_version": 3, "version": "=1.4.5"}, "info": {"category": "", "code": "A001", "extra": {}, "invocation_id": "f97fdb3c-61cf-49fb-b595-3dc00faaa631", "level": "info", "msg": "Running with dbt=1.4.5", "name": "MainReportVersion", "pid": 63990, "thread": "MainThread", "ts": "2023-09-28T15:46:04.254826Z"}}
{"data": {}, "info": {"category": "", "code": "M013", "extra": {}, "invocation_id": "f97fdb3c-61cf-49fb-b595-3dc00faaa631", "level": "info", "msg": "Warning: No packages were found in packages.yml", "name": "DepsNoPackagesFound", "pid": 63990, "thread": "MainThread", "ts": "2023-09-28T15:46:04.277178Z"}}

Environment

- OS: MacOS 12.7
- Python: 3.10
- dbt: 1.4.5

Which database adapter are you using with dbt?

postgres

Additional Context

No response

@andy-clapson andy-clapson added bug Something isn't working triage labels Sep 28, 2023
@github-actions github-actions bot changed the title [Bug] .yaml prefix not recognized for packages.yml [CT-3169] [Bug] .yaml prefix not recognized for packages.yml Sep 28, 2023
@dbeatty10 dbeatty10 self-assigned this Sep 28, 2023
@dbeatty10
Copy link
Contributor

Thanks for reaching out @andy-clapson !

Totally reasonable to expect that .yml and .yaml would be interchangable (especially since the YAML folks recommend the .yaml extension).

This is covered by #5002, so I'm going to close this as a duplicate.

If anyone is interested in tackling this effort, there's some guidance here (that covers all of "profiles.yml", "dbt_project.yml", "selectors.yml", "packages.yml"): #5002 (comment)

i.e., the end goal is that all of these would be interchangeable:

profiles.yml profiles.yaml
dbt_project.yml dbt_project.yaml
selectors.yml selectors.yaml
packages.yml packages.yaml

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
@dbeatty10 dbeatty10 removed the triage label Sep 28, 2023
@dbeatty10 dbeatty10 removed their assignment Sep 28, 2023
@andy-clapson
Copy link
Contributor Author

Thanks for reaching out @andy-clapson !

Totally reasonable to expect that .yml and .yaml would be interchangable (especially since the YAML folks recommend the .yaml extension).

This is covered by #5002, so I'm going to close this as a duplicate.

If anyone is interested in tackling this effort, there's some guidance here (that covers all of "profiles.yml", "dbt_project.yml", "selectors.yml", "packages.yml"): #5002 (comment)

i.e., the end goal is that all of these would be interchangeable:

profiles.yml profiles.yaml
dbt_project.yml dbt_project.yaml
selectors.yml selectors.yaml
packages.yml packages.yaml

ah! my searching failed me, but I did try and look for an existing issue - thanks!

@dbeatty10
Copy link
Contributor

Sure thing @andy-clapson ! Thanks again for opening this issue 🏆

You nudged us to review #5002, and then we updated the issue title (for better searchability) and re-categorized it as a handy feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants