Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalogs.yml parsing #11162

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

catalogs.yml parsing #11162

wants to merge 6 commits into from

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Dec 17, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

TODO:

  • move plain-old data objects to dbt/artifacts/resources
  • add catalogs to build
  • clean up exceptions
  • more functional tests for validation

@cla-bot cla-bot bot added the cla:yes label Dec 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 44.76190% with 58 lines in your changes missing coverage. Please review.

Project coverage is 62.34%. Comparing base (892c545) to head (f5b370d).

❗ There is a different number of reports uploaded between BASE (892c545) and HEAD (f5b370d). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (892c545) HEAD (f5b370d)
unit 2 1
integration 10 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11162       +/-   ##
===========================================
- Coverage   88.93%   62.34%   -26.60%     
===========================================
  Files         187      188        +1     
  Lines       24092    24196      +104     
===========================================
- Hits        21427    15084     -6343     
- Misses       2665     9112     +6447     
Flag Coverage Δ
integration ?
unit 62.34% <44.76%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.34% <44.76%> (-0.08%) ⬇️
Integration Tests 62.34% <44.76%> (-26.60%) ⬇️

@MichelleArk MichelleArk changed the title Catalogs parsing catalogs.yml parsing Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant