[Regression] --no-write-json causes 'Manifest' object has no attribute 'group_map' error in 1.9 beta

[joellabes]

Is this a regression in a recent version of dbt-core?

• I believe this is a regression in dbt-core functionality
• I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

I just noticed that in the 1.9 beta, running dbt build --no-write-json causes a 'Manifest' object has no attribute 'group_map' error.

From git history, this seems to have been introduced as part of #10775

Expected/Previous Behavior

The invocation works correctly.

Steps To Reproduce

1. Run dbt build --no-write-json
2. Observe below log output

Relevant log output

21:53:33  Finished running  in 0 hours 0 minutes and 2.00 seconds (2.00s).
21:53:33  Encountered an error:
'Manifest' object has no attribute 'group_map'
21:53:33  Traceback (most recent call last):
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 153, in wrapper
    result, success = func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 103, in wrapper
    return func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 235, in wrapper
    return func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 264, in wrapper
    return func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 311, in wrapper
    return func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/requires.py", line 328, in wrapper
    return func(*args, **kwargs)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/cli/main.py", line 204, in build
    results = task.run()
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/task/runnable.py", line 577, in run
    result = self.execute_with_hooks(selected_uids)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/task/runnable.py", line 514, in execute_with_hooks
    before_run_status = self.before_run(adapter, selected_uids)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/task/run.py", line 732, in before_run
    group_lookup.init(self.manifest, selected_uids)
  File "/Users/joel/venvs/dbt-prod/lib/python3.8/site-packages/dbt/task/group_lookup.py", line 16, in init
    for group_name, node_ids in manifest.group_map.items():
AttributeError: 'Manifest' object has no attribute 'group_map'

Environment

- OS: macOS 14.7.1
- Python: Python 3.8.10 (I know 3.8 is EOL but I also repro'd this on dbt Cloud versionless so that's not the cause)
- dbt (working version):
joel@Joel-Labes joel-sandbox % dbt -v                                                              
Core:
  - installed: 1.8.7
  - latest:    1.8.8 - Update available!

Plugins:
  - snowflake: 1.8.4 - Up to date!
  - postgres:  1.8.2 - Up to date!

- dbt (regression version):
joel@Joel-Labes joel-sandbox % dbt -v                   
Core:
  - installed: 1.9.0-b2
  - latest:    1.8.8    - Ahead of latest version!

Plugins:
  - snowflake: 1.9.0b1 - Ahead of latest version!
  - postgres:  1.9.0b1 - Ahead of latest version!

Also observed on dbt Cloud versionless

Which database adapter are you using with dbt?

snowflake

Additional Context

No response

[dbeatty10]

Thanks for reporting this @joellabes ! And thanks for tracing it back to the suspected PR 🤩

Reprex

Create this file:

seeds/my_seed.csv

id
1

Run this command:

dbt build --select my_seed --no-write-json

Get log output similar to what was originally reported.

It doesn't matter if there are groups defined or assigned or not. Also doesn't matter if the target directory with artifacts already exists or not.