Allow configuration of snapshot column names #10608
Merged
+470
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10608 +/- ##
==========================================
+ Coverage 88.96% 89.00% +0.03%
==========================================
Files 181 181
Lines 22975 22956 -19
==========================================
- Hits 20439 20431 -8
+ Misses 2536 2525 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Sep 3, 2024
peterallenwebb
approved these changes
Sep 20, 2024
dev-requirements.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@main | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@snapshot_column_names | |||
There was a problem hiding this comment.
I know it's obvious, but I'm just leaving a reminder that these changes will need to be left out of the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10185
Problem
We hardcode the column names in snapshot tables.
Solution
Allow configuring column names.
Checklist