From 3e6cd2116878e3c8cc308b42c21b49110275cf32 Mon Sep 17 00:00:00 2001 From: Quigley Malcolm Date: Wed, 11 Oct 2023 15:26:50 -0700 Subject: [PATCH] Fix `test_backwards_compatible_versions` test When we regenerated the v10 test manifest artifact, it started having the `metricflow_time_sine` model, and it didn't previously. This caused `test_backwards_compatible_versions` to start failing because it was no longer identified as having modified state for v10. The test has been altered accordingly --- tests/functional/artifacts/test_previous_version_state.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/artifacts/test_previous_version_state.py b/tests/functional/artifacts/test_previous_version_state.py index 7bd56036d6f..3e7b047c2e2 100644 --- a/tests/functional/artifacts/test_previous_version_state.py +++ b/tests/functional/artifacts/test_previous_version_state.py @@ -376,8 +376,10 @@ def test_compare_state_current(self, project): def test_backwards_compatible_versions(self, project): # manifest schema version 4 and greater should always be forward compatible - for schema_version in range(4, self.CURRENT_EXPECTED_MANIFEST_VERSION): + for schema_version in range(4, 10): self.compare_previous_state(project, schema_version, True, 1) + for schema_version in range(10, self.CURRENT_EXPECTED_MANIFEST_VERSION): + self.compare_previous_state(project, schema_version, True, 0) def test_nonbackwards_compatible_versions(self, project): # schema versions 1, 2, 3 are all not forward compatible