From 8bdea5654864041f343e2b3919f70a717f9e4d96 Mon Sep 17 00:00:00 2001 From: Emily Rockman Date: Mon, 5 Feb 2024 20:20:13 -0600 Subject: [PATCH 1/2] remove fire_event_if_test --- dbt_common/events/functions.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dbt_common/events/functions.py b/dbt_common/events/functions.py index 6402c791..ad2c40e4 100644 --- a/dbt_common/events/functions.py +++ b/dbt_common/events/functions.py @@ -132,13 +132,6 @@ def fire_event_if( fire_event(lazy_e(), level=level) -# a special case of fire_event_if, to only fire events in our unit/functional tests -def fire_event_if_test( - lazy_e: Callable[[], BaseEvent], level: Optional[EventLevel] = None -) -> None: - fire_event_if(conditional=("pytest" in sys.modules), lazy_e=lazy_e, level=level) - - # top-level method for accessing the new eventing system # this is where all the side effects happen branched by event type # (i.e. - mutating the event history, printing to stdout, logging From 119e4610759a68d4fdde4ee6e855172b9873adcc Mon Sep 17 00:00:00 2001 From: Emily Rockman Date: Tue, 6 Feb 2024 08:13:33 -0600 Subject: [PATCH 2/2] changelog --- .changes/unreleased/Under the Hood-20240206-081323.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/Under the Hood-20240206-081323.yaml diff --git a/.changes/unreleased/Under the Hood-20240206-081323.yaml b/.changes/unreleased/Under the Hood-20240206-081323.yaml new file mode 100644 index 00000000..f5565b06 --- /dev/null +++ b/.changes/unreleased/Under the Hood-20240206-081323.yaml @@ -0,0 +1,6 @@ +kind: Under the Hood +body: Remove `fire_event_if_test` method +time: 2024-02-06T08:13:23.722615-06:00 +custom: + Author: emmyoop + Issue: "66"