Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable suppression of logging event dictionary parsing errors #203

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 10, 2024

resolves #202

Description

Instead of using sys.modules to detect the presence of pytest, use the "PYTEST_CURRENT_TEST" environment variable. Also include the original exception in the logged error for easier debugging.

Checklist

@gshank gshank requested a review from a team as a code owner October 10, 2024 20:44
@cla-bot cla-bot bot added the cla:yes label Oct 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.33%. Comparing base (8f2b1d5) to head (fcaf56f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   68.28%   68.33%   +0.04%     
==========================================
  Files          52       52              
  Lines        3374     3373       -1     
==========================================
+ Hits         2304     2305       +1     
+ Misses       1070     1068       -2     
Flag Coverage Δ
unit 68.33% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 1e93d0d Oct 10, 2024
17 checks passed
@gshank gshank deleted the suppress_logging_serialization_exceptions branch October 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants