You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there is hardcoding of target.type == 'postgres' etc. whose logic that we want in adapter implementations rather than in dbt-core.
Acceptance criteria
there is no hard-coded adapter names (like target.type == 'postgres')
there is a clear and easy way for adapter maintainers to customize the test cases if their data platform doesn't support the syntax in the base adapter
Impact to Other Teams
This change directly affects dbt-bigquery, dbt-postgres, and dbt-redshift that may need to accommodate any change. The appropriate Impact: Adapters label has been added.
Will backports be required?
Backport to 1.7.latest. The backport 1.7.latest label has been added.
See #192 for proposed cross-database to_date macro that is intended to make test customization on a per-adapter basis either completely unnecessary or exceedingly rare.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
Remove hard-coded adapter logic from tests for date_spine macros
[CT-3254] Remove hard-coded adapter logic from tests for date_spine macros
Oct 25, 2023
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.
Housekeeping
Short description
@jwills asked within dbt-labs/dbt-core#8307 (comment) if we can make it easier for adapter maintainers to specify their preferred date format within the tests for
date_spine
and supporting macros.Currently, there is hardcoding of
target.type == 'postgres'
etc. whose logic that we want in adapter implementations rather than in dbt-core.Acceptance criteria
target.type == 'postgres'
)Impact to Other Teams
This change directly affects dbt-bigquery, dbt-postgres, and dbt-redshift that may need to accommodate any change. The appropriate
Impact: Adapters
label has been added.Will backports be required?
Backport to 1.7.latest. The
backport 1.7.latest
label has been added.Context
See dbt-labs/dbt-core#8172, dbt-labs/dbt-core#8616, and dbt-labs/dbt-core#8307 (comment) for background context.
See #192 for proposed cross-database
to_date
macro that is intended to make test customization on a per-adapter basis either completely unnecessary or exceedingly rare.The text was updated successfully, but these errors were encountered: