Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3254] Remove hard-coded adapter logic from tests for date_spine macros #223

Closed
1 task done
dbeatty10 opened this issue Oct 25, 2023 · 3 comments
Closed
1 task done
Labels

Comments

@dbeatty10
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

@jwills asked within dbt-labs/dbt-core#8307 (comment) if we can make it easier for adapter maintainers to specify their preferred date format within the tests for date_spine and supporting macros.

Currently, there is hardcoding of target.type == 'postgres' etc. whose logic that we want in adapter implementations rather than in dbt-core.

Acceptance criteria

  • there is no hard-coded adapter names (like target.type == 'postgres')
  • there is a clear and easy way for adapter maintainers to customize the test cases if their data platform doesn't support the syntax in the base adapter

Impact to Other Teams

This change directly affects dbt-bigquery, dbt-postgres, and dbt-redshift that may need to accommodate any change. The appropriate Impact: Adapters label has been added.

Will backports be required?

Backport to 1.7.latest. The backport 1.7.latest label has been added.

Context

See dbt-labs/dbt-core#8172, dbt-labs/dbt-core#8616, and dbt-labs/dbt-core#8307 (comment) for background context.

See #192 for proposed cross-database to_date macro that is intended to make test customization on a per-adapter basis either completely unnecessary or exceedingly rare.

@github-actions github-actions bot changed the title Remove hard-coded adapter logic from tests for date_spine macros [CT-3254] Remove hard-coded adapter logic from tests for date_spine macros Oct 25, 2023
@jtcohen6
Copy link
Contributor

Moving to dbt-adapters since the relevant tests have also moved there:

@jtcohen6 jtcohen6 transferred this issue from dbt-labs/dbt-core May 23, 2024
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 20, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
mikealfare pushed a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants