Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example code #7

Open
marcqualie opened this issue Dec 23, 2020 · 2 comments
Open

Add example code #7

marcqualie opened this issue Dec 23, 2020 · 2 comments
Assignees

Comments

@marcqualie
Copy link
Collaborator

In order to test our code and see examples of what our apps should look like, we can add an examples/ folder and then run rubocop against those files on CI, so we can enforce our rules are working when doing PRs.

@marcqualie marcqualie self-assigned this Dec 23, 2020
@IlkhamGaysin
Copy link
Contributor

won't it be testing rubocop itself? if we wanna examples we can take a look to ruby docs?

@marcqualie
Copy link
Collaborator Author

The examples are what our application code should look like, not what the rubocop config looks like.

e.g. we want to ensure when we change a rule, it's enforcing the correct behaviour on an example file, like a rails controller or model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants