Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all instances of Buffer with Uint8Array #277

Open
dawsbot opened this issue Apr 4, 2024 · 3 comments
Open

Replace all instances of Buffer with Uint8Array #277

dawsbot opened this issue Apr 4, 2024 · 3 comments

Comments

@dawsbot
Copy link
Owner

dawsbot commented Apr 4, 2024

https://sindresorhus.com/blog/goodbye-nodejs-buffer

@paulmillr
Copy link

migrating from sha3 to @noble/hashes would make it easier. it's also smaller and audited

@dawsbot
Copy link
Owner Author

dawsbot commented Apr 12, 2024

migrating from sha3 to @noble/hashes would make it easier. it's also smaller and audited

I'd love some help on this @paulmillr - I pulled in @noble/hashes and tried to replace Buffer in one of the files but it seems the data-types of Uint8Array are not as flexible and I was unable to find a way around this. Would you be open to a PR to help this get started? 🙏

@paulmillr
Copy link

@dawsbot what do you mean by "not as flexible"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants