feat: switch to graphql-subscriptions-continued for proper typing #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I was completely stuck. This helped me to unblock my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the types so there's no need for a duplicate version from what's already in
graphql-subscriptions(or was in the 3.0 release branch anyway, which I just released asgraphql-subscriptions-continued).Completely up to you whether you want to trust an unproven library not published by apollo directly, but I don't want to wait around for them to finally fix the types, and since I fixed it there, and will publish this fork for my own use anyway, might as well push it upstream if you want it 😉