Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of variables related to time to float #280

Open
ghsdh3409 opened this issue Mar 31, 2018 · 1 comment · May be fixed by #281
Open

Change type of variables related to time to float #280

ghsdh3409 opened this issue Mar 31, 2018 · 1 comment · May be fixed by #281

Comments

@ghsdh3409
Copy link

  • Currently, type of variables related to time is int. Thus, seekTo or currentTime could be not accurate.
  • I will make pull request by myself.
@ghsdh3409 ghsdh3409 linked a pull request Mar 31, 2018 that will close this issue
Open
@jazz-messenger
Copy link

Could someone please approve this pull request? I am running into issues as currentTime reports seconds without fractions on Android devices. The IOS version provides milliseconds in its e.currentTime implementation.
As a consequence, we have an inconsistent behaviour on different OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change type of variables related to time to float hayanmind/react-native-youtube
2 participants
@ghsdh3409 @jazz-messenger