docs: fixed missing references #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebshow
reviewed
Nov 8, 2017
| results.append(result) | ||
| return results | ||
| """Return results as ``list``.""" | ||
| return [result async for result in self] |
There was a problem hiding this comment.
This async list comprehensions are sweet, but do they work with Python 3.5?
There was a problem hiding this comment.
I hope so 😆 We will find out when #11 is done.
There was a problem hiding this comment.
Spoiler: They don't 👹
They were an enhancement introduced in Python 3.6 with PEP 530
|
Other than my 1 comment, this is LGTM. Please address comment and I will merge. |
* Allows building documentation in strict mode with: `sphinx-build -qnNW docs docs/_build/html` (closes davebshow#9)
jirikuncar
force-pushed
the
9-autodoc
branch
from
97aa6e2
to
6b9a904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sphinx-build -qnNW docs docs/_build/html(closes docs: incomplete objects.inv for intersphinx #9)