Skip to content

Merge pull request #141 from cowlicks/default-tokio #17

Merge pull request #141 from cowlicks/default-tokio

Merge pull request #141 from cowlicks/default-tokio #17

GitHub Actions / clippy succeeded Oct 3, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 1567 in src/tree/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
    --> src/tree/merkle_tree.rs:1567:34
     |
1567 | fn block_node(index: u64, value: &Vec<u8>) -> Node {
     |                                  ^^^^^^^^ help: change this to: `&[u8]`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
     = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 486 in src/tree/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

if let can be simplified with `.unwrap_or_default()`

warning: if let can be simplified with `.unwrap_or_default()`
   --> src/tree/merkle_tree.rs:482:39
    |
482 |                       additional_nodes: if let Some(additional_upgrade) = p.additional_upgrade {
    |  _______________________________________^
483 | |                         additional_upgrade
484 | |                     } else {
485 | |                         vec![]
486 | |                     },
    | |_____________________^ help: replace it with: `p.additional_upgrade.unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
    = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default

Check warning on line 267 in src/oplog/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::vec::Drain<'_, common::store::StoreInfo>`

warning: useless conversion to the same type: `std::vec::Drain<'_, common::store::StoreInfo>`
   --> src/oplog/mod.rs:267:17
    |
267 |                 infos_to_flush.into_vec().drain(0..1).into_iter().collect();
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `infos_to_flush.into_vec().drain(0..1)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default