Skip to content

fix: error message variable order #15

fix: error message variable order

fix: error message variable order #15

Triggered via push September 1, 2024 07:02
Status Failure
Total duration 15m 29s
Artifacts

ci.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 9 warnings
test-macos
Process completed with exit code 101.
test-linux
Process completed with exit code 101.
test-windows
Process completed with exit code 1.
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: src/tree/merkle_tree.rs#L1567
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/tree/merkle_tree.rs:1567:34 | 1567 | fn block_node(index: u64, value: &Vec<u8>) -> Node { | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
if let can be simplified with `.unwrap_or_default()`: src/tree/merkle_tree.rs#L482
warning: if let can be simplified with `.unwrap_or_default()` --> src/tree/merkle_tree.rs:482:39 | 482 | additional_nodes: if let Some(additional_upgrade) = p.additional_upgrade { | _______________________________________^ 483 | | additional_upgrade 484 | | } else { 485 | | vec![] 486 | | }, | |_____________________^ help: replace it with: `p.additional_upgrade.unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
useless conversion to the same type: `std::vec::Drain<'_, common::store::StoreInfo>`: src/oplog/mod.rs#L267
warning: useless conversion to the same type: `std::vec::Drain<'_, common::store::StoreInfo>` --> src/oplog/mod.rs:267:17 | 267 | infos_to_flush.into_vec().drain(0..1).into_iter().collect(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `infos_to_flush.into_vec().drain(0..1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-macos
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-linux
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build-extra
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test-windows
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/