Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Silent new releases without version bump #2350

Open
Dialga opened this issue Dec 12, 2024 · 3 comments
Open

BUG Silent new releases without version bump #2350

Dialga opened this issue Dec 12, 2024 · 3 comments

Comments

@Dialga
Copy link

Dialga commented Dec 12, 2024

Describe the bug
The initial binary release for linux:

sha1sum
c5a23ac1c4964bd03b6954023d7b82db4ddf3480  qsv-1.0.0-x86_64-unknown-linux-gnu.zip
Archive:  qsv-1.0.0-x86_64-unknown-linux-gnu.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
     1092  12-02-24 14:15   README
 90809288  12-02-24 14:15   qsv
 66392984  12-02-24 14:15   qsvdp
 16462200  12-02-24 14:15   qsvlite

The new silently updated release yesterday containing more files:

sha1sum
f9a7056e794970b268845e16bae63250e40a164f  qsv-1.0.0-x86_64-unknown-linux-gnu.zip.1
Archive:  qsv-1.0.0-x86_64-unknown-linux-gnu.zip.1
  Length     Date   Time    Name
 --------    ----   ----    ----
     1092  12-02-24 14:15   README
 90809288  12-02-24 14:15   qsv
 86526168  12-02-24 15:41   qsv_glibc-2.31
      196  12-02-24 15:41   qsv_glibc-2.31_rust_version_info.txt
 72692768  12-02-24 15:36   qsv_nightly
      382  12-02-24 15:36   qsv_nightly_rust_version_info.txt
 66392984  12-02-24 14:15   qsvdp
 66511696  12-02-24 15:41   qsvdp_glibc-2.31
 51587864  12-02-24 15:36   qsvdp_nightly
 16462200  12-02-24 14:15   qsvlite
 16482640  12-02-24 15:41   qsvlite_glibc-2.31
 51600424  12-02-24 15:36   qsvlite_nightly
 90313704  12-02-24 15:51   qsvp
 66216888  12-02-24 15:51   qsvpdp
 16265624  12-02-24 15:51   qsvplite

To Reproduce

Expected behavior
I expect each newly released zip package to remain the same after release, not to be silently updated later without a version bump.
This is creating additional maintenance burden for package maintainers due to the file and checksum change.

Desktop (please complete the following information):

  • OS: Linux
  • qsv Version 1.0.0
    Unsure if other OSes affected.

Solution
Prefer subsequent releases to be version bumped or have a suffix _full to distinguish from the initial release. Or just bundle the full release with all the binaries during the initial version release.

@jqnatividad
Copy link
Collaborator

Thanks @Dialga for the report.

Unfortunately, the prebuilt archives are built incrementally, with separate GitHub workflows adding prebuilt binary variants for each platform.

At all times, the zip archive is re-signed as files are added to ensure authenticity of the archive.

It normally takes me a day after a release to incrementally build the release archives.

I'm thinking the solution is to create a finalization workflow that will create a manifest of all the files in archive and mark it "finalized". Further, I'll add checks to the existing incremental workflows so they will not add files to an archive once its finalized.

Does that work for your requirements?

@rzmk
Copy link
Collaborator

rzmk commented Dec 12, 2024

What about building all the files into a draft release's assets and then publish when they're all ready?

@jqnatividad
Copy link
Collaborator

@rzmk , that's a great idea! Will do that instead for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants