Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on QSV_SKIP_FORMAT_CHECK env var for all property tests #2308

Closed
jqnatividad opened this issue Nov 22, 2024 · 1 comment · Fixed by #2309
Closed

turn on QSV_SKIP_FORMAT_CHECK env var for all property tests #2308

jqnatividad opened this issue Nov 22, 2024 · 1 comment · Fixed by #2309
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.

Comments

@jqnatividad
Copy link
Collaborator

As property tests would sometimes produces random test input that causes the mime-type input checking introduced in #2304 to have false positive failures.

@jqnatividad jqnatividad added the enhancement New feature or request. Once marked with this label, its in the backlog. label Nov 22, 2024
@jqnatividad
Copy link
Collaborator Author

jqnatividad commented Nov 23, 2024

instead of doing this, simplify input format checking to just scanning for supported file extensions (csv, tsv, tab, ssv), as the mime-type checking is prone to false positives.

Keep the QSV_SKIP_FORMAT env var to skip even this simplified scanning, as sometimes, some users use input with unconventional file extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant