Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log report.json to DC at the end of a run #82

Open
pradh opened this issue Sep 24, 2021 · 3 comments
Open

Log report.json to DC at the end of a run #82

pradh opened this issue Sep 24, 2021 · 3 comments

Comments

@pradh
Copy link
Contributor

pradh commented Sep 24, 2021

Unlike the Import UI, which lets us monitor or debug usage, we have no insight into the stand-alone client.

One thing we could do is to ship the report.json content at the end of the run. It should be well under 1MB in size.

Perhaps we can have a new recon API endpoint to save the report.json in a GCS bucket as a time-stamped file.

To make sure disconnected (or poorly-connected) users can use the tool, we should probably do this at the very end so even if interrupted the command will have done its job.

Finally, if we also report back the GCS file path, users can then more conveniently share that URL while asking us questions (rather than sending along a report.json).

@chejennifer, @beets ... wdyt?

@beets
Copy link

beets commented Sep 24, 2021

Sounds good! Some additional stats might be helpful as well - like # of files / type, commands & flags used, etc.
Expect a lot of repeats though, much more so than with the current UI. Maybe a flag to turn off uploading the report.json to gcs (but still sends an analytics ping)?

@pradh
Copy link
Contributor Author

pradh commented Sep 24, 2021

Yeah, command args are part of the report, but there are probably some more things we can add to it.

Having a flag to turn off GCS upload SG.

@chejennifer
Copy link
Contributor

Yeah, that sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants