Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example code snippet in the Autoscalers section of the docs index page #904

Closed
marcelovilla opened this issue Sep 2, 2024 · 2 comments · Fixed by #905
Closed

Comments

@marcelovilla
Copy link
Contributor

marcelovilla commented Sep 2, 2024

Describe the issue:

In the Autoscalers section of the docs index page, there's an incorrect example code snippet on how to create a KubeCluster and scale it. Here is screenshot:

image

Initially, I thought it was a duplicate snippet but @jacobtomlinson has pointed out it's actually an incorrect example and it should depict how to adapt a cluster to use the autoscaler.

@jacobtomlinson
Copy link
Member

Thanks! The example isn't a duplicate, but it is broken. See my comment on your PR #905 (review)

@marcelovilla
Copy link
Contributor Author

@jacobtomlinson ah, I see! That makes sense. Let me update the issue title and description to better convey this.

@marcelovilla marcelovilla changed the title Irrevelant/duplicate code snippet at the end of documentation index Incorrect example code snippet in the Autoscalers section of the docs index page Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants