Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [GPU Logic Bug] SELECT (CASE <DATE> WHEN <DATE> THEN <DATE> END) FROM <table> brings Error #1339

Open
qwebug opened this issue Jun 5, 2024 · 2 comments
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer

Comments

@qwebug
Copy link

qwebug commented Jun 5, 2024

What happened:

SELECT (CASE <DATE> WHEN <DATE> THEN <DATE> END) FROM <table> brings different results, when using CPU and GPU execution.

What you expected to happen:

It is the same result, when using CPU and GPU execution.

Minimal Complete Verifiable Example:

import pandas as pd
import dask.dataframe as dd
from dask_sql import Context

c = Context()

df0 = pd.DataFrame({
    'c0': [True],
})
t0 = dd.from_pandas(df0, npartitions=1)

c.create_table('t0', t0, gpu=False)
c.create_table('t0_gpu', t0, gpu=True)

print('CPU Result:')
result1= c.sql("SELECT (CASE DATE '2005-05-21' WHEN DATE '1981-07-19' THEN DATE '2015-04-07' END ) FROM t0").compute()
print(result1)

print('GPU Result:')
result2= c.sql("SELECT (CASE DATE '2005-05-21' WHEN DATE '1981-07-19' THEN DATE '2015-04-07' END ) FROM t0_gpu").compute()
print(result2)

Result:

INFO:numba.cuda.cudadrv.driver:init
CPU Result:
  CASE Utf8("2005-05-21") WHEN Utf8("1981-07-19") THEN Utf8("2015-04-07") END
0                                                NaT                         
GPU Result:
  CASE Utf8("2005-05-21") WHEN Utf8("1981-07-19") THEN Utf8("2015-04-07") END
0                                               <NA>        

Anything else we need to know?:

Environment:

@qwebug qwebug added bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer labels Jun 5, 2024
@qwebug
Copy link
Author

qwebug commented Jun 18, 2024

This problem came up at dask-sql version: 2023.6.0 .
And it has been fixed at dask-sql version: 2024.5.0, after my verification.
Thanks to the developers for their contributions.

@griffith-maker
Copy link

Dask-sql version 2024.3.0 has fixed this issue, thanks for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Development

No branches or pull requests

2 participants