Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Citation on the CANVAS locus page not being converted to a number #129

Closed
hdashnow opened this issue Dec 18, 2024 · 3 comments
Closed

Citation on the CANVAS locus page not being converted to a number #129

hdashnow opened this issue Dec 18, 2024 · 3 comments

Comments

@hdashnow
Copy link
Member

hdashnow commented Dec 18, 2024 •
edited
Loading

[pmid:38627134] isn't being converted to a numerical citation.

It looks like it's correctly formatted in STRchive-loci.json in both the details and the references, but it's not present in STRchive-citations.json.

Ideally, the fallback should still produce a numerical citation. And then I also need to figure out why it's missing from STRchive-citations.json.

Screenshot 2024-12-18 at 5 22 38 AM Screenshot 2024-12-18 at 5 22 23 AM
@laurelhiatt
Copy link
Contributor

I think it's because it doesn't have an @, it needs the @, alas

@laurelhiatt
Copy link
Contributor

created a pull request

@hdashnow
Copy link
Member Author

Duh! Thank you. I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hdashnow @laurelhiatt