From a88d31a41fee3b5ccc6a7c7e7f0e7d2352cc43bc Mon Sep 17 00:00:00 2001 From: Gabriel Terwesten Date: Wed, 4 Oct 2023 11:31:06 +0200 Subject: [PATCH 1/2] [native_assets_cli] Clarify meaning of `targetAndroidNdkApi` in docs --- pkgs/native_assets_cli/lib/src/model/build_config.dart | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/native_assets_cli/lib/src/model/build_config.dart b/pkgs/native_assets_cli/lib/src/model/build_config.dart index 786aefe4d..bb0e303b8 100644 --- a/pkgs/native_assets_cli/lib/src/model/build_config.dart +++ b/pkgs/native_assets_cli/lib/src/model/build_config.dart @@ -68,6 +68,11 @@ class BuildConfig { /// When compiling for Android, the API version to target. /// + /// This property is not to be confused with + /// [`targetSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#targetsdkversion) + /// but is instead the + /// [`minSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#minsdkversion). + /// /// Required when [targetOs] equals [OS.android]. /// /// Not available in [dryRun]. From 7f3abb25488e544c47721e5c582718dfb7b5a393 Mon Sep 17 00:00:00 2001 From: Gabriel Terwesten Date: Wed, 4 Oct 2023 16:32:08 +0200 Subject: [PATCH 2/2] ++ --- .../lib/src/model/build_config.dart | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/native_assets_cli/lib/src/model/build_config.dart b/pkgs/native_assets_cli/lib/src/model/build_config.dart index bb0e303b8..e1aecbadb 100644 --- a/pkgs/native_assets_cli/lib/src/model/build_config.dart +++ b/pkgs/native_assets_cli/lib/src/model/build_config.dart @@ -66,16 +66,16 @@ class BuildConfig { late final IOSSdk? _targetIOSSdk; - /// When compiling for Android, the API version to target. - /// - /// This property is not to be confused with - /// [`targetSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#targetsdkversion) - /// but is instead the - /// [`minSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#minsdkversion). + /// When compiling for Android, the minimum Android SDK API version to that + /// the compiled code will be compatible with. /// /// Required when [targetOs] equals [OS.android]. /// /// Not available in [dryRun]. + /// + /// For more information about the Android API version, refer to + /// [`minSdkVersion`](https://developer.android.com/ndk/guides/sdk-versions#minsdkversion) + /// in the Android documentation. int? get targetAndroidNdkApi { _ensureNotDryRun(); return _targetAndroidNdkApi;