From d6c129eab9ff82551872ffdfe4aac5ecac62a5d2 Mon Sep 17 00:00:00 2001 From: Gabriel Terwesten Date: Mon, 9 Dec 2024 21:47:11 +0100 Subject: [PATCH] Disable `dart test` in `example/build/native_dynamic_linking` on windows --- .github/workflows/native.yaml | 5 ++++- .../test/example/native_dynamic_linking_test.dart | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/native.yaml b/.github/workflows/native.yaml index 3ed905927..84ea83274 100644 --- a/.github/workflows/native.yaml +++ b/.github/workflows/native.yaml @@ -142,7 +142,10 @@ jobs: - run: dart --enable-experiment=native-assets test working-directory: pkgs/${{ matrix.package }}/example/build/native_dynamic_linking/ - if: ${{ matrix.package == 'native_assets_cli' && matrix.sdk == 'dev' && !matrix.breaking-change }} + # TODO(https://github.com/dart-lang/native/issues/190): Enable on windows once + # https://github.com/dart-lang/sdk/commit/903eea6bfb8ee405587f0866a1d1e92eea45d29e + # has landed in dev channel. + if: ${{ matrix.package == 'native_assets_cli' && matrix.sdk == 'dev' && !matrix.breaking-change && matrix.os != 'windows' }} - run: dart --enable-experiment=native-assets test working-directory: pkgs/${{ matrix.package }}/example/build/native_add_app/ diff --git a/pkgs/native_assets_cli/test/example/native_dynamic_linking_test.dart b/pkgs/native_assets_cli/test/example/native_dynamic_linking_test.dart index 4fb7c956b..b70e28274 100644 --- a/pkgs/native_assets_cli/test/example/native_dynamic_linking_test.dart +++ b/pkgs/native_assets_cli/test/example/native_dynamic_linking_test.dart @@ -6,7 +6,7 @@ 'mac-os': Timeout.factor(2), 'windows': Timeout.factor(10), }) -// TODO(https://github.com/dart-lang/native/issues/190): Enable once +// TODO(https://github.com/dart-lang/native/issues/190): Enable on windows once // https://github.com/dart-lang/sdk/commit/903eea6bfb8ee405587f0866a1d1e92eea45d29e // has landed in dev channel. @TestOn('!windows')