Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid status line tests and replace them with valid status line tests #1018

Merged
merged 13 commits into from
Sep 15, 2023

Conversation

brianquinlan
Copy link
Collaborator

@brianquinlan brianquinlan commented Sep 13, 2023

  • Remove invalid status line tests because reasonable client behavior is too varied
  • Add valid status line tests
  • Make all clients pass them.

Fixes #1013


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Sep 14, 2023
@github-actions github-actions bot removed the package:cupertino_http Issues related to package:cupertino_http label Sep 15, 2023
@brianquinlan brianquinlan changed the title Throw an exception on incorrect status lines. Remove invalid status line tests and replace them with valid status line tests Sep 15, 2023
@brianquinlan brianquinlan merged commit decefa6 into dart-lang:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cronet_http is failing "without status code" test
2 participants