diff --git a/.github/workflows/cronet.yml b/.github/workflows/cronet.yml index cc055f3b25..2f48f951ef 100644 --- a/.github/workflows/cronet.yml +++ b/.github/workflows/cronet.yml @@ -58,8 +58,10 @@ jobs: uses: reactivecircus/android-emulator-runner@v2 if: always() && steps.install.outcome == 'success' with: - # This should match the minSdkVersion in - # pkgs/cronet_http/android/build.gradle. + # api-level/minSdkVersion should be help in sync in: + # - .github/workflows/cronet.yml + # - pkgs/cronet_http/android/build.gradle + # - pkgs/cronet_http/example/android/app/build.gradle api-level: 24 target: ${{ matrix.package == 'cronet_http_embedded' && 'google_apis' || 'playstore' }} arch: x86_64 diff --git a/pkgs/cronet_http/android/build.gradle b/pkgs/cronet_http/android/build.gradle index a07bf2096b..885e64a811 100644 --- a/pkgs/cronet_http/android/build.gradle +++ b/pkgs/cronet_http/android/build.gradle @@ -46,7 +46,10 @@ android { } defaultConfig { - // This should match the version tested in .github/workflows/cronet.yml + // api-level/minSdkVersion should be help in sync in: + // - .github/workflows/cronet.yml + // - pkgs/cronet_http/android/build.gradle + // - pkgs/cronet_http/example/android/app/build.gradle minSdkVersion 24 } diff --git a/pkgs/cronet_http/example/android/app/build.gradle b/pkgs/cronet_http/example/android/app/build.gradle index 679eb53343..eaeec89b2a 100644 --- a/pkgs/cronet_http/example/android/app/build.gradle +++ b/pkgs/cronet_http/example/android/app/build.gradle @@ -46,6 +46,10 @@ android { applicationId "io.flutter.cronet_http_example" // You can update the following values to match your application needs. // For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration. + // api-level/minSdkVersion should be help in sync in: + // - .github/workflows/cronet.yml + // - pkgs/cronet_http/android/build.gradle + // - pkgs/cronet_http/example/android/app/build.gradle minSdkVersion 24 targetSdkVersion flutter.targetSdkVersion versionCode flutterVersionCode.toInteger()