From e67cdd5349e07c3c479ee917f2bc52bc37a722a2 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Tue, 21 May 2024 18:12:13 +0200 Subject: [PATCH] Reebable skipped tests (#3708) --- _test/test/help_test.dart | 3 +-- .../build_script_generate_test.dart | 15 +++++---------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/_test/test/help_test.dart b/_test/test/help_test.dart index 0e1c53d9c..e03809ca9 100644 --- a/_test/test/help_test.dart +++ b/_test/test/help_test.dart @@ -54,8 +54,7 @@ Future _testHelpCommand(List args, {String? checkContent}) async { expect(result.exitCode, equals(0), reason: 'should give a successful exit code'); expect(result.stderr, isEmpty, - reason: 'Should output nothing on stderr', - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + reason: 'Should output nothing on stderr',); expect(result.stdout, isNot(contains('"Unhandled exception"')), reason: 'Should not print an unhandled exception'); if (checkContent != null) { diff --git a/build_runner/test/build_script_generate/build_script_generate_test.dart b/build_runner/test/build_script_generate/build_script_generate_test.dart index de27aa442..a024d1ddd 100644 --- a/build_runner/test/build_script_generate/build_script_generate_test.dart +++ b/build_runner/test/build_script_generate/build_script_generate_test.dart @@ -37,8 +37,7 @@ builders: ]).create(); var result = await runPub('a', 'run', args: ['build_runner', 'build']); - expect(result.stderr, isEmpty, - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + expect(result.stderr, isEmpty); expect( result.stdout, contains( @@ -57,8 +56,7 @@ builders: ]).create(); var result = await runPub('a', 'run', args: ['build_runner', 'build']); - expect(result.stderr, isEmpty, - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + expect(result.stderr, isEmpty); expect( result.stdout, isNot(contains( @@ -87,8 +85,7 @@ builders: ''') ]).create(); var result = await runPub('a', 'run', args: ['build_runner', 'build']); - expect(result.stderr, isEmpty, - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + expect(result.stderr, isEmpty); expect(result.stdout, contains('could not be parsed')); }); @@ -103,8 +100,7 @@ builders: ''') ]).create(); var result = await runPub('a', 'run', args: ['build_runner', 'build']); - expect(result.stderr, isEmpty, - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + expect(result.stderr, isEmpty); expect( result.stdout, contains('Could not load imported package "unknown_package" ' @@ -123,8 +119,7 @@ global_options: ]).create(); var result = await runPub('a', 'run', args: ['build_runner', 'build']); - expect(result.stderr, isEmpty, - skip: 'https://github.com/dart-lang/sdk/issues/50592'); + expect(result.stderr, isEmpty); expect( result.stdout, allOf(