Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapService serializes created_at and updated_at #95

Open
jocubeit opened this issue Mar 3, 2023 · 2 comments
Open

MapService serializes created_at and updated_at #95

jocubeit opened this issue Mar 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jocubeit
Copy link

jocubeit commented Mar 3, 2023

This causes issues later during type conversion.

Specifically the following line:

https://github.com/dukefirehawk/angel/blob/9b85007072fdcd19bd79237ba2e3bf4e23c8021f/packages/framework/lib/src/core/map_service.dart#L87

If you amend the line to remove the serialization to an ISO 8601 string, then everything works as it should:

var now = DateTime.now(); //.toIso8601String();

Similarly the following lines would also need amending.

in the modify method:
https://github.com/dukefirehawk/angel/blob/9b85007072fdcd19bd79237ba2e3bf4e23c8021f/packages/framework/lib/src/core/map_service.dart#L117

and in the update method:
https://github.com/dukefirehawk/angel/blob/9b85007072fdcd19bd79237ba2e3bf4e23c8021f/packages/framework/lib/src/core/map_service.dart#L146

I raised an issue over at dart-backend/belatuk-examples#3 which highlights the problem in the graphql example.

I'm happy to make the changes to the MapService class and push a merge request if you like.

@jocubeit
Copy link
Author

jocubeit commented Mar 3, 2023

Actually I'm having other issues now, as soon as I query nested objects. I'll investigate further and get back to this issue.

@dukefirehawk
Copy link
Collaborator

PR is always welcome.

@dukefirehawk dukefirehawk added the bug Something isn't working label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants