Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

integrate well with Angular2 #11

Open
jmesserly opened this issue Apr 1, 2015 · 4 comments
Open

integrate well with Angular2 #11

jmesserly opened this issue Apr 1, 2015 · 4 comments

Comments

@jmesserly
Copy link
Contributor

from @matanlurey at #9 (comment)

https://github.com/angular/angular. I can reference to you a copy of their Change Detector API, but basically they already have a tree-pruning based dirty checking on all controllers. We're hoping to pipe Observable.changes into their Change Detector API when available.

it sounds like #10 is the first step, and favoring a simple ChangeNotifier over Observable. What else can we do?

@jmesserly
Copy link
Contributor Author

btw, I'm happy with moving/integrating code from/to/with angular change detector code. At the very least, testing that the integration works well.

Fun history: a very old version of this library was called "watcher" and was ported by @sigmundch from Angular1 :). For better or worse we got pulled in the ES7 O.o direction, but this library was inspired by Angular. There's something poetic about it returning to its roots with Angular2 integration.

@yjbanov
Copy link

yjbanov commented Apr 2, 2015

Even funnier: Angular 1's watchers are considered broken and being removed from Angular 2. Angular 2's tree pruning works by marking branches of the component tree as dirty whenever a node notifies the change detection system that it is dirty.

@matanlurey
Copy link
Contributor

@yjbanov, is it possible we could get Victor from Angular to work with John in the near future? I'd be happy to help, of course, but it might be more effective for the change detector guy to work on the change detector :)

@yjbanov
Copy link

yjbanov commented Apr 2, 2015

@vsavkin please prepare to answer John's questions :)

@matanlurey I'm assuming this issue is about performance. Could you summarize your findings and point out issues?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants