forked from vvuk/VerticalTabs
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VerticalTabs CSS forces its own background colours, preventing other extensions doing so (FIX IS KNOWN) #13
Comments
stilez
changed the title
CSS bug - VT overrides other extensions' control of tab background colour
CSS bug - VT forces its own background colours, preventing other extensions doing so (FIX IS KNOWN)
Mar 10, 2015
stilez
changed the title
CSS bug - VT forces its own background colours, preventing other extensions doing so (FIX IS KNOWN)
VerticalTabs CSS forces its own background colours, preventing other extensions doing so (FIX IS KNOWN)
Mar 10, 2015
stilez
added a commit
to stilez/VerticalTabs
that referenced
this issue
Sep 3, 2015
See darrinhenein#13 SCENARIO: Firefox and tab Mix Plus. Set up some nice garish background colours in T.M.P. for loaded/unloaded/unread tabs. They work fine. Now install VerticalTabs. They immediately lose their T.M.P. colours. CAUSE OF ISSUE: There's a css issue in the theming css files (win7.css etc). The extension doesn't just handle vertical tabs, it also expects to recolour tab borders/backgrounds to "default colours" or "VerticalTab theme colours" (Why, why?!) when recolouring is completely unrelated to the extensions job of vertical formatting. This kills any tab background colour or formatting by extensions like TabMix Plus, ColorfulTabs, etc. SOLUTIONS/WORKAROUNDS: Solution 1 - just kill all theming to be honest. Vertical-ing a tab bar doesn't mean re-colouring it. Solution 2 - remove all "background" color code from the Win7 and other OS css files. For Windows this means removing (at least) these lines: .tabbrowser-tab { -moz-box-pack: start; -moz-box-flex: 0; -moz-appearance: none ! important; <------------- DELETE THIS LINE background: transparent ! important; <------------- DELETE THIS LINE Those two lines seem to fix it enough for ColorfulTabs and others to semi-work. Really needs to kill all theming though. Vertical tabs should do just that - not enforce colours as well. The colours should already exist in the current tab bar (or be copied from it by the extension), or some of the !important's shouldn't be there.
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
* remove direct settings access by lib/verticaltabs.js * move default settings restore function to WebExt * move console debug logging to WebExt * empower WebExt to decide settings
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
It's already fully functional but needs CSS adjustments to look native again
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
* also remove SDK simple-prefs and Services module * remove unneeded and partically forbidden CSS from options.html
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
…ntext menu (darrinhenein#13) this is necessary to be able to change these settings at all, since about:config won't be possible anymore
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
WebExt contextmenus are getting displayed on every HTML document which is ridiculous
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
* all tabs get listed * pinned tab status is displayed * text label, pinned tab status gets dynamically updated * possible to switch tabs with click
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
* update tab's icon and selected status dynamically * automatically scroll to selected tab if necessary * workaround to show tab placeholder/default icon + add-on manager icon * slightly improve CSS * split legacy sidebar CSS with WebExt sidebar CSS
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
DavidShepherdson
pushed a commit
to DavidShepherdson/VerticalTabs
that referenced
this issue
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SCENARIO:
Firefox and tab Mix Plus. Set up some nice garish background colours in T.M.P. for loaded/unloaded/unread tabs. They work fine. Now install VerticalTabs. They immediately lose their T.M.P. colours.
CAUSE OF ISSUE:
There's a css issue in the theming css files (win7.css etc). The extension doesn't just handle vertical tabs, it also expects to recolour tab borders/backgrounds to "default colours" or "VerticalTab theme colours" (Why, why?!) when recolouring is completely unrelated to the extensions job of vertical formatting. This kills any tab background colour or formatting by extensions like TabMix Plus, ColorfulTabs, etc.
SOLUTIONS/WORKAROUNDS:
Solution 1 - just kill all theming to be honest. Vertical-ing a tab bar doesn't mean re-colouring it.
Solution 2 - remove all "background" color code from the Win7 and other OS css files. For Windows this means removing (at least) these lines:
.tabbrowser-tab {
-moz-box-pack: start;
-moz-box-flex: 0;
-moz-appearance: none ! important; <------------- DELETE THIS LINE
background: transparent ! important; <------------- DELETE THIS LINE
Those two lines seem to fix it enough for ColorfulTabs and others to semi-work. Really needs to kill all theming though.
The text was updated successfully, but these errors were encountered: