Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162 error reading filesShownTracker: in path: /home/node/filesShownTracker.txt #164

Open
M4Rv opened this issue Dec 10, 2024 · 8 comments

Comments

@M4Rv
Copy link

M4Rv commented Dec 10, 2024

Hi there,
I love this module and just updated mine to the latest master!

It seems with PR #162 there is some error (I run the magicmirroros, hence mm is running inside docker):
error reading filesShownTracker: in path: /home/node/filesShownTracker.txt

Also, I beliebe the README.md needs an update to inform users about the new parameter.
@klalle would you mind having a look (as you were the owner of the PR)?

Cheers :)
Marvin

@klalle
Copy link
Contributor

klalle commented Dec 10, 2024

@M4Rv sure, I'll have a look.
Does the MM-docker have a volume to the rpi-os? otherwise the file might be lost when docker restarts..!?
A quick fix that might work is to change the file directory to the module path: const filePath = 'modules/MMM-BackgroundSlideshow/filesShownTracker.txt'; try out this buggfix
that seems to work when not on docker... but where is the config-file stored? it should be stored on a persistent volume!?
it looks as if you access the config on /opt/mm/mounts/, wonder where that is in the docker, i'll have a look

@klalle
Copy link
Contributor

klalle commented Dec 10, 2024

think I found it here
image
and it kinda looks as if the modules are persistent as well:
image
@M4Rv Can you try the branch I posted above, if it doesn't persist the file when restarting the docker, we can try to put it next to the config-file.

@M4Rv
Copy link
Author

M4Rv commented Dec 10, 2024

Thanks! Currently I am struggling with another issue (#118).
But it appears the filesShownTracker.txt is also persisted in the /home/node/ directory, at least it survives a restart of the container.

You are correct with the 3 persistent mounts for config, modules, and css. Will try to check out your branch soon.

@klalle
Copy link
Contributor

klalle commented Dec 10, 2024

I updated the readme in the bugfix-branch as well...
@M4Rv that 118 bug sounds like a memory issue or something...

  • do you have a stacktrace?
  • tried using firefox instead of electron as frontend? (see my setup) - might be hard to do when using your docker setup?

@M4Rv
Copy link
Author

M4Rv commented Dec 10, 2024

Thanks, I checked out your fork branch. The filesShownTracker.txt is now correctly stored in the directory of this module!

For my other issue: Unfortunately I couldn't find a stacktrace. It is really hard for me to debug.
I don't see any memory issue on the raspi, also all other services continue to work fine on the raspi.

I assume your set-up would avoid the error, because when I access my mirror from my main computer via http://ip:8080 the mirror continues to work. However, on the interface on the display of the mirror does not automatically recover.

@klalle
Copy link
Contributor

klalle commented Dec 10, 2024

@M4Rv Can you confirm that the bugfix fixed the initial bug?

@M4Rv
Copy link
Author

M4Rv commented Dec 10, 2024

Yes, it does. I'd say you could send the PR.

@klalle klalle mentioned this issue Dec 11, 2024
@klalle
Copy link
Contributor

klalle commented Dec 11, 2024

@M4Rv done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants