Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml assumes that the godbledger server image has been built #34

Open
davidalpert opened this issue Apr 13, 2022 · 0 comments

Comments

@davidalpert
Copy link
Contributor

I recently cloned this repo on a new macbook and ran into the following error When running make docker-start:

Pulling app (godbledger:latest)...
ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing.

Continue with the new image? [yN]y
Pulling app (godbledger:latest)...
ERROR: pull access denied for godbledger, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

After some investigation, it appears that:

  1. docker-compose.yml references the godbledger image
  2. there is no dockerfile in this repo for the godbledger image

I believe that this repo assumes that the build-docker target has been successfully run in the core https://github.com/darcys22/godbledger repo (step 1 from https://github.com/darcys22/godbledger#running-in-docker) before running the make docker-start target in this repo.

I suggest updating the README.md file in this repo with some additional instructions either to run make docker-build in the core repo first or to share this error message and remediation steps in README.md under a new Known Issues section.

davidalpert added a commit to davidalpert/godbledger-web that referenced this issue Apr 13, 2022
this is a prereuqisite of this repo's docker-build target
and must be done seperately since the dockefile for the
server image lives in the core godbledger repo not in
this one.
darcys22 added a commit that referenced this issue Apr 14, 2022
GH-34 add build instructions for the godbledger image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant