Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to handle null return values #1353

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

WhitWaldo
Copy link
Contributor

@WhitWaldo WhitWaldo commented Oct 6, 2024

Description

Added some simple checks to handle null response values.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1349 and #1296

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Copy link

@KrylixZA KrylixZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment.

src/Dapr.Client/DaprClientGrpc.cs Show resolved Hide resolved
philliphoff
philliphoff previously approved these changes Oct 11, 2024
Copy link
Collaborator

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise LGTM.

@WhitWaldo WhitWaldo merged commit 19cb481 into dapr:master Oct 11, 2024
10 checks passed
@WhitWaldo WhitWaldo deleted the get-metadata-fix branch October 11, 2024 06:57
@bhanuprakash-1
Copy link

How do we know in which SDK version(or when) this fix will be available? I'm using the 1.14.0 version (latest available as of today based on this: https://www.nuget.org/packages/Dapr.Client).

@WhitWaldo
Copy link
Contributor Author

@bhanuprakash-1 This will be available as part of the 1.15 client release available in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaprClient.GetMetadataAsync() throwing Exception
4 participants